ENH: Add lazy copy to to_timestamp and to_period #50575
Conversation
phofl
changed the title
pandas/core/series.py
Outdated
| new_values = self._values | ||
| if copy: | ||
| new_values = new_values.copy() | ||
| new_obj = self.copy(deep=copy) |
There was a problem hiding this comment.
Do this copy after the index isinstance check?
There was a problem hiding this comment.
Moved, kept the df as is to keep it consistent with the previous behavior
| self, method="to_timestamp" | ||
| ) | ||
| setattr(new_obj, "index", new_index) | ||
| return new_obj |
There was a problem hiding this comment.
I am not fully sure, but we might want to keep the __finalize__ call? (although of course not a new object was constructed here, that already happened now in the copy() call)
There was a problem hiding this comment.
Ah, I see this is how it is done for the DataFrame implementation, so that's probably OK then
| return self._constructor(new_values, index=new_index).__finalize__( | ||
| self, method="to_timestamp" | ||
| ) | ||
| setattr(new_obj, "index", new_index) |
There was a problem hiding this comment.
Is the reason not to use new_obj.index = new_index for performance?
There was a problem hiding this comment.
Ah, I see this is how it is done for the DataFrame implementation
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.